Attention is currently required from: Martin Roth, Chiranjeevi Rapolu, Tim Wawrzynczak, John Zhao, Duncan Laurie, Brandon Breitenstein, Patrick Rudolph.
7 comments:
File src/soc/intel/tigerlake/early_tcss.c:
The caller doesn't even care about res. This can be just defined in this function rather than accepting from caller.
struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer rsp;
PMC_IPC_TCSS_DISC_REQ_RES,
port_map.usb3_port,
port_map.usb2_port,
0, 0, 0, 0);
Can you please reflow this to fill in the 96-column limit?
Patch Set #5, Line 268: struct tcss_port_map port_map
Instead of passing in the entire structure here, you can pass in a pointer to the entry?
const struct tcss_port_map *port_map
Patch Set #5, Line 270: *rbuf = NULL
This is problematic. rbuf is set to NULL here and the driver expects the caller to pass in a valid pointer. This whole file is passing it wrong. (Fixed in CB:51232).
Not required. This is set on line 273.
Patch Set #5, Line 319: if (!display_init_required())
if (!CONFIG(EARLY_TCSS_DISPLAY) || !display_init_required())
return;
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
uint8_t usb3_port; /* USB2 Port Number */
uint8_t usb2_port; /* USB3 Port Number */
This can be dropped now that there is a separate structure for the port map?
To view, visit change 51194. To unsubscribe, or for help writing mail filters, visit settings.