Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47831 )
Change subject: util/cbfstool: Introduce concept of mmap_window ......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16: This change broke booting on the ASRock E350M1. With this commit (and building with `make -j2`), the layout is changed, and serial console output (and boot) stops after bootblock.
``` $ more defconfig CONFIG_ANY_TOOLCHAIN=y CONFIG_VENDOR_ASROCK=y CONFIG_NO_POST=y CONFIG_VGA_BIOS=y CONFIG_VGA_BIOS_FILE="pci1002,9802.rom" CONFIG_BOARD_ASROCK_E350M1=y CONFIG_SEABIOS_MASTER=y ```
### runs
``` $ build/cbfstool build/coreboot.rom print FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs master header 0x0 cbfs header 32 none fallback/romstage 0x80 stage 187284 none fallback/ramstage 0x2dc80 stage 119179 none config 0x4ae80 raw 234 none revision 0x4afc0 raw 675 none build_info 0x4b2c0 raw 95 none fallback/dsdt.aml 0x4b380 raw 9598 none cmos_layout.bin 0x4d940 cmos_layout 1228 none pci1002,9802.rom 0x4de40 optionrom 65536 none fallback/postcar 0x5de80 stage 17952 none fallback/payload 0x62500 simple elf 70483 none payload_config 0x738c0 raw 1621 none payload_revision 0x73f40 raw 233 none (empty) 0x74080 null 3652888 none s3nv 0x3efdc0 raw 8192 none (empty) 0x3f1e00 null 44312 none bootblock 0x3fcb40 bootblock 12912 none ```
### fails
``` $ /dev/shm/coreboot/build/cbfstool /dev/shm/coreboot.rom print FMAP REGION: COREBOOT Name Offset Type Size Comp cbfs master header 0x0 cbfs header 32 none s3nv 0x80 raw 8192 none fallback/romstage 0x20c0 stage 187284 none fallback/ramstage 0x2fcc0 stage 119179 none config 0x4cec0 raw 234 none revision 0x4d000 raw 675 none build_info 0x4d300 raw 95 none fallback/dsdt.aml 0x4d3c0 raw 9598 none cmos_layout.bin 0x4f980 cmos_layout 1228 none pci1002,9802.rom 0x4fe80 optionrom 65536 none fallback/postcar 0x5fec0 stage 17952 none fallback/payload 0x64540 simple elf 70495 none payload_config 0x75900 raw 1621 none payload_revision 0x75f80 raw 233 none (empty) 0x760c0 null 3697240 none bootblock 0x3fcb40 bootblock 12912 none ```
``` coreboot-4.13-1928-gad581984a6 Thu Feb 11 10:25:44 UTC 2021 bootblock starting (log level: 7)... FMAP: Found "FLASH" version 1.1 at 0x0. FMAP: base = 0xffc00000 size = 0x400000 #areas = 3 FMAP: area COREBOOT found @ 200 (4193792 bytes) CBFS: mcache @0x00034e00 built for 15 files, used 0x304 of 0x2000 bytes CBFS: Found 'fallback/romstage' @0x20c0 size 0x2db94 in mcache @0x00034e60 BS: bootblock times (exec / console): total (unknown) / 35 ms ```