Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'd keep them.
Why? `git blame` shows they've been commented out since this file was added to coreboot. Doing a grep for CPU_INTEL_MODEL_F6X or CPU_INTEL_MODEL_1066X shows nothing in coreboot except here
I guess because of CB:25565 (which would have to uncomment the entries anyway)
Ah, I see. Elyes, if you resurrect CB:25565, would you be OK with just adding those Kconfig options back in with that patch?
This is not a big deal. I'm ok.
but I don't understand why you want remove it?
They are inhere since the file was added.
I'd give "-1" just to see other reviews.
To view, visit change 44218. To unsubscribe, or for help writing mail filters, visit settings.