8 comments:
File src/soc/amd/picasso/Makefile.inc:
Could you put a comment on DEP_FILES explaining what it's doing? […]
Done
Patch Set #65, Line 259: $(DEP_FILES) \
This does not make sense to me. Why would we want to add dependent files to arguments of AMDFWTOOL. […]
Done
File src/southbridge/amd/pi/hudson/Kconfig:
Patch Set #65, Line 68: string "AMD PSP Firmware config file"
Remove this line and move the text to a help block? You don't need two 'string' entries and this do […]
Done
Patch Set #65, Line 69: if CPU_AMD_PI_00730F01
change this to a "depends on" statement so the option doesn't appear for other processors?
Only avalon is active now.
File src/southbridge/amd/pi/hudson/Makefile.inc:
#SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin
#SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin
#SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin
Why not remove these instead of commenting them out?
Done
File util/amdfwtool/amdfwtool.c:
Patch Set #65, Line 222: /* static */
Is the comment supposed to be on a different line? This seems odd.
Done
remove D from the unused list?
Done
File util/amdfwtool/data_parse.c:
Patch Set #65, Line 401: fprintf(stderr, "Modules name \"%s\" is not valid\n", oneline);
Nicely done. […]
Done
To view, visit change 42859. To unsubscribe, or for help writing mail filters, visit settings.