View Change
2 comments:
File src/acpi/acpigen.c:
Patch Set #5, Line 1928:
void acpigen_call_method(const char *name, unsigned char *params, int params_len)
{
int i;
char ud[] = "____";
for (i = 0; i < 4; i++) {
if ((name[i] == '\0')) {
acpigen_emit_stream(ud, 4 - i);
break;
}
acpigen_emit_byte(name[i]);
}
for (i = 0; i < params_len; i++)
acpigen_write_byte(params[i]);
}
Why is this necessary?
Patch Set #5, Line 1944:
void acpigen_write_store_var(const char *name, uint8_t value)
{
int i;
char ud[] = "____";
acpigen_write_store();
acpigen_emit_byte(value);
for (i = 0; i < 4; i++) {
if ((name[i] == '\0')) {
acpigen_emit_stream(ud, 4 - i);
break;
}
acpigen_emit_byte(name[i]);
}
}
Why is this necessary?
To view, visit change 41620. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb67bd756dc8ae1dfd2d40020c273325583df0f
Gerrit-Change-Number: 41620
Gerrit-PatchSet: 10
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s@intel.com>
Gerrit-Reviewer: Daniel Kang <daniel.h.kang@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kiran2 Kumar <kiran2.kumar@intel.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 06 Jun 2020 01:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment