6 comments:
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
Extra indent
u8 vref_tmp = 0;
vref_tmp = imp_vref_sel[odt][drv_type];
Can be combined into one line.
Patch Set #2, Line 44: switch (drv_type) {
This can be simplified by
static const char *const drv_type_str[IMP_DRV_MAX] = {
[DRVP] = "DRVP",
...
[ODTN] = "ODTN",
};
if (drv_type >= IMP_DRV_MAX)
die(...);
drv_str = drv_type_str[drv_type];
Patch Set #2, Line 89: dramc_sw_impedance_cal
Please add this function to dramc_pi_api.h in this patch.
Add 'const' for it.
Patch Set #2, Line 92: cal_res
No need to initialize it.
To view, visit change 44704. To unsubscribe, or for help writing mail filters, visit settings.