Patch Set 8:

In gpio_*.h add '#include "gpio.h"'

As these are all includes and not classes this would cause a redefinition and wouldn't be able to compile.

and include guards for for better reading

What do you mean with "guards"?

View Change

To view, visit change 31504. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic61871f5cf95ac3da93892fa2f7721e682176c8d
Gerrit-Change-Number: 31504
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <migy@darmstadt.ccc.de>
Gerrit-Reviewer: Felix Singer <migy@darmstadt.ccc.de>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Tue, 19 Feb 2019 21:54:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment