build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34138 ) Change subject: new file: toshiba/Kconfig new file: toshiba/Kconfig.name new file: toshiba/satellite_u940/Kconfig new file: toshiba/satellite_u940/Kconfig.name new file: toshiba/satellite_u940/Makefile.inc new file: toshiba/satellite_u940/acpi/ec.asl new file: toshiba/satellite_u940/acpi/platform.asl new file: toshiba/satellite_u940/acpi/superio.asl new file: toshiba/satellite_u940/acpi_tables.c new file: toshiba/satellite_u940/board_info.txt new file: toshiba/satellite_u940/devicetree.cb new file: toshiba/satellite_u940/dsdt.asl new file: toshiba/satellite_u940/gma-mainboard.ads new file: toshiba/satellite_u940/gpio.c new file: toshiba/satellite_u940/hda_verb.c new file: toshiba/satellite_u940/mainboard.c new file: toshiba/satellite_u940/romstage.c ...................................................................... Patch Set 1: (17 comments) https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... File src/mainboard/toshiba/satellite_u940/mainboard.c: https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 31: /* 00 */ 0x1b, 0x00, 0x00, 0x00, 0x10, 0x19, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 32: /* 10 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 33: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 34: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x11, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, 0x04, 0x0a, 0x14, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 35: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 36: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 37: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 38: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 39: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 40: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 41: /* a0 */ 0x00, 0x00, 0x00, 0x84, 0x81, 0x00, 0x00, 0x61, 0x64, 0x00, 0x00, 0x08, 0x64, 0x19, 0x00, 0x98, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 42: /* b0 */ 0x00, 0x00, 0x00, 0x3a, 0xff, 0x00, 0x00, 0x00, 0x00, 0x07, 0x00, 0x1f, 0x00, 0x0b, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 43: /* c0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 44: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 45: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 46: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters https://review.coreboot.org/c/coreboot/+/34138/1/src/mainboard/toshiba/satel... PS1, Line 51: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/34138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If87c327cd15fe44479d6738c45acbd510873d994 Gerrit-Change-Number: 34138 Gerrit-PatchSet: 1 Gerrit-Owner: franlego98 franlego98 <new.francisco.1998@tuta.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: franlego98 franlego98 <new.francisco.1998@tuta.io> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 08 Jul 2019 14:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment