View Change

3 comments:

• File src/ec/google/chromeec/ec.c:

  • Patch Set #4, Line 745: }

    I have mild preference for this, which is a little more explicit about what we are doing. But I'll let coreboot people decide ,-)

    if (google_chromeec_get_uptime_info(&rsp))
       return false;

    return (rsp.ec_reset_flags & RESET_FLAG_AP_WATCHDOG);

  • Patch Set #4, Line 747: #ifndef __PRE_RAM__

    Do the functions above make sense if __PRE_RAM__ is defined?

• File src/vendorcode/google/chromeos/watchdog.c:

  • Patch Set #4, Line 43: elog_add_event(ELOG_TYPE_ASYNC_HW_TIMER_EXPIRED);

    I find this code difficult to parse.

    I'd rather do:

    int hw_timer_expired = 0;

    if (CONFIG) {
       hw_timer_expired = google_chromeec_get_ap_watchdog_flag();
    } else {
     ...
    }

    if (hw_timer_expired)
      elog_add_event(ELOG_TYPE_ASYNC_HW_TIMER_EXPIRED);

To view, visit change 31834. To unsubscribe, or for help writing mail filters, visit settings.