Attention is currently required from: Matt DeVillier, Julius Werner, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 7: [TEST]
Okay, I noticed now that a bunch of mainboards override the default for config CHROMEOS. […]
As long as nobody relies on the `default y` in newer mainboards, I would also
vote for adapting the linter.
I don't remember if there was ever a rule against defaulting to CHROMEOS that
was just forgotten, or if it's just implied by the way abuild is written.
To view, visit change 49056. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4bc22f70be5b8d8efa35f0cc8aa2d36a5531a
Gerrit-Change-Number: 49056
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 23:45:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment