Attention is currently required from: Nico Huber, Paul Menzel, Felix Held.
5 comments:
File src/cpu/x86/lapic/lapic.c:
Patch Set #5, Line 9: lvt0_mask
It's the same for LVT1, should we use it there too?
Done
Patch Set #5, Line 13: uint32_t lvt0_val = LAPIC_LVT_REMOTE_IRR | LAPIC_SEND_PENDING;
Maybe comment that this is the mask and value (well minus EXTINT but see below) used by […]
Ack
Patch Set #5, Line 29: | LAPIC_SPIV_ENABLE);
Sets spurious interrupt to vector 0? And LVT0 for AP used vector 0 too? […]
Ack
Patch Set #5, Line 34: lvt0_val |= LAPIC_DELIVERY_MODE_FIXED | LAPIC_LVT_MASKED;
10.5.2 Valid Interrupt Vectors […]
Ack
The spec (B.1) says […]
I cannot figure out what "this one" here referred to.
To view, visit change 42434. To unsubscribe, or for help writing mail filters, visit settings.