Patch Set 23:

libpayload payloads like *coreinfo* do not build for me anymore with GCC 10.2.0. It works with GCC 9.3.0 for example.

```
$ cd payloads/coreinfo
$ make olddefconfig
$ make -j4
[…]
    LPCC       build/coreinfo.elf (LINK)
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(exception.libc.o):/dev/shm/coreboot/payloads/libpayload/include/x86/arch/exception.h:64: multiple definition of `__packed'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(main.libc.o):/dev/shm/coreboot/payloads/libpayload/include/x86/arch/exception.h:64: first defined here
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci_rh.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:153: multiple definition of `HcInterruptStatusReg'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:153: first defined here
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci_rh.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:142: multiple definition of `HcFmRemainingReg'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:142: first defined here
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci_rh.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:137: multiple definition of `HcCommandStatusMask'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:137: first defined here
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci_rh.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:133: multiple definition of `HcCommandStatusReg'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:133: first defined here
/dev/shm/coreboot/util/crossgcc/xgcc/lib/gcc/i386-elf/10.2.0/../../../../i386-elf/bin/ld: /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci_rh.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:118: multiple definition of `HcControlMask'; /dev/shm/coreboot/payloads/coreinfo/build/libpayload/bin/../lib/libpayload.a(ohci.libc.o):/dev/shm/coreboot/payloads/libpayload/drivers/usb/ohci_private.h:118: first defined here
[…]
```

"/coreboot/payloads/libpayload/include/x86/arch/exception.h:64: multiple definition of `__packed'; "
this is because "-fcommon" option changed to "-fno-common" in GCC10 ( https://gcc.gnu.org/gcc-10/porting_to.html )
"__attribute__((__packed__))" may fix that error.

for the others, I have no idea

View Change

To view, visit change 42251. To unsubscribe, or for help writing mail filters, visit settings.