[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/nissa/var/riven: Configure Acoustic noise mitigation

[Paul Menzel (Code Review)]

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Paul Menzel has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/84908?usp=email )

Change subject: mb/google/nissa/var/riven: Configure Acoustic noise mitigation
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84908/comment/195e012e_36d9faae?usp... :
PS2, Line 9: - Enable Acoustic noise mitigation
           : - Set slow slew rate VCCIA and VCCGT to SLEW_FAST_4
           : - Set FastPkgCRampDisable VCCIA and VCCGT to 1
How did you determine these values?

https://review.coreboot.org/c/coreboot/+/84908/comment/b73ceef3_969382e1?usp... :
PS2, Line 14: TEST=build FW and check fsp log.
Shouldn’t the “noise” also be measured somehow?