3 comments:
File util/rockchip/make_idb.py:
b for consistency. Or use "B" consistently throughout this file.
Done
Patch Set #5, Line 60: buf[:4] = self.bytesToList(chip)
If we're modifying it like this, I think we should use bytearray, which simplfies things: […]
Done. Thanks, it's better!
Patch Set #5, Line 133: chip.encode('utf-8')
It's better to encode 'chip' inside makeIDB() in my opinion.
Done
To view, visit change 45447. To unsubscribe, or for help writing mail filters, visit settings.