I noticed we don't have a unit test for fmap yet. When that unit test is written, make sure it includes cases for calling fmap_locate_area and fmap_find_region_name with all the combinations of NULL parameters.

Patch set 2:Code-Review +2

View Change

To view, visit change 48531. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie712d040b1c2383dcc8884e5f779c3591ccf0163
Gerrit-Change-Number: 48531
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Jan Dabros <jsd@semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 10 Dec 2020 15:57:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment