Kyösti Mälkki has uploaded this change for review.

View Change

AGESA binaryPI: Add AGESA entry timestamps

Change-Id: I71e09d3bc4c8657979d447b90fb6ac7cae959479
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
---
M src/drivers/amd/agesa/eventlog.c
M src/drivers/amd/agesa/state_machine.c
M src/northbridge/amd/agesa/state_machine.h
3 files changed, 37 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31515/1
diff --git a/src/drivers/amd/agesa/eventlog.c b/src/drivers/amd/agesa/eventlog.c
index 152011e..887da30 100644
--- a/src/drivers/amd/agesa/eventlog.c
+++ b/src/drivers/amd/agesa/eventlog.c
@@ -16,6 +16,7 @@
#include <console/console.h>
#include <stdint.h>
#include <string.h>
+#include <timestamp.h>

#include <northbridge/amd/agesa/state_machine.h>
#include <northbridge/amd/agesa/BiosCallOuts.h>
@@ -30,54 +31,78 @@
{
AGESA_STRUCT_NAME func;
const char *name;
+ uint32_t entry_id;
+ uint32_t exit_id;
};

static const struct agesa_mapping entrypoint[] = {
{
.func = AMD_INIT_RESET,
.name = "AmdInitReset",
+ .entry_id = TS_AGESA_INIT_RESET_START,
+ .exit_id = TS_AGESA_INIT_RESET_DONE,
},
{
.func = AMD_INIT_EARLY,
.name = "AmdInitEarly",
+ .entry_id = TS_AGESA_INIT_EARLY_START,
+ .exit_id = TS_AGESA_INIT_EARLY_DONE,
},
{
.func = AMD_INIT_POST,
.name = "AmdInitPost",
+ .entry_id = TS_AGESA_INIT_POST_START,
+ .exit_id = TS_AGESA_INIT_POST_DONE,
},
{
.func = AMD_INIT_RESUME,
.name = "AmdInitResume",
+ .entry_id = TS_AGESA_INIT_RESUME_START,
+ .exit_id = TS_AGESA_INIT_RESUME_DONE,
},
{
.func = AMD_INIT_ENV,
.name = "AmdInitEnv",
+ .entry_id = TS_AGESA_INIT_ENV_START,
+ .exit_id = TS_AGESA_INIT_ENV_DONE,
},
{
.func = AMD_INIT_MID,
.name = "AmdInitMid",
+ .entry_id = TS_AGESA_INIT_MID_START,
+ .exit_id = TS_AGESA_INIT_MID_DONE,
},
{
.func = AMD_INIT_LATE,
.name = "AmdInitLate",
+ .entry_id = TS_AGESA_INIT_LATE_START,
+ .exit_id = TS_AGESA_INIT_LATE_DONE,
},
{
.func = AMD_S3LATE_RESTORE,
.name = "AmdS3LateRestore",
+ .entry_id = TS_AGESA_S3_LATE_START,
+ .exit_id = TS_AGESA_S3_LATE_DONE,
},
#if !defined(AMD_S3_SAVE_REMOVED)
{
.func = AMD_S3_SAVE,
.name = "AmdS3Save",
+ .entry_id = TS_AGESA_INIT_RTB_START,
+ .exit_id = TS_AGESA_INIT_RTB_DONE,
},
#endif
{
.func = AMD_S3FINAL_RESTORE,
.name = "AmdS3FinalRestore",
+ .entry_id = TS_AGESA_S3_FINAL_START,
+ .exit_id = TS_AGESA_S3_FINAL_DONE,
},
{
.func = AMD_INIT_RTB,
.name = "AmdInitRtb",
+ .entry_id = TS_AGESA_INIT_RTB_START,
+ .exit_id = TS_AGESA_INIT_RTB_DONE,
},
};

@@ -92,6 +117,8 @@
for (i = 0; i < ARRAY_SIZE(entrypoint); i++) {
if (task->func == entrypoint[i].func) {
task->function_name = entrypoint[i].name;
+ task->ts_entry_id = entrypoint[i].entry_id;
+ task->ts_exit_id = entrypoint[i].exit_id;
break;
}
}
diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c
index f676192..4d56218 100644
--- a/src/drivers/amd/agesa/state_machine.c
+++ b/src/drivers/amd/agesa/state_machine.c
@@ -21,6 +21,8 @@
#include <arch/cpu.h>
#include <bootstate.h>
#include <cbfs.h>
+#include <cbmem.h>
+#include <timestamp.h>

#include <northbridge/amd/agesa/state_machine.h>
#include <northbridge/amd/agesa/agesa_helper.h>
@@ -263,12 +265,18 @@
AMD_CONFIG_PARAMS *StdHeader = aip.NewStructPtr;
ASSERT(StdHeader->Func == func);

+ if (task.ts_entry_id)
+ timestamp_add_now(task.ts_entry_id);
+
if (ENV_ROMSTAGE)
final = romstage_dispatch(cb, func, StdHeader);

if (ENV_RAMSTAGE)
final = ramstage_dispatch(cb, func, StdHeader);

+ if (task.ts_exit_id)
+ timestamp_add_now(task.ts_exit_id);
+
agesawrapper_trace(final, StdHeader, task.function_name);
ASSERT(final < AGESA_FATAL);

diff --git a/src/northbridge/amd/agesa/state_machine.h b/src/northbridge/amd/agesa/state_machine.h
index 45d57c2..f1dd139 100644
--- a/src/northbridge/amd/agesa/state_machine.h
+++ b/src/northbridge/amd/agesa/state_machine.h
@@ -60,6 +60,8 @@

AGESA_STRUCT_NAME func;
const char *function_name;
+ uint32_t ts_entry_id;
+ uint32_t ts_exit_id;
};

void agesa_state_on_entry(struct agesa_state *task, AGESA_STRUCT_NAME func);

To view, visit change 31515. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71e09d3bc4c8657979d447b90fb6ac7cae959479
Gerrit-Change-Number: 31515
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-MessageType: newchange