Attention is currently required from: Kapil Porwal, Ivy Jian, Eric Lai, Utkarsh H Patel, Sukumar Ghorai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70196 )
Change subject: mb/google/rex: Cnfigure `SLP_S0_GATE_R` aka GPP_H14 PIN low
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I think we should wait Intel verify this, weird.
I agree that and looking at Brya, this PIN is set to high but if you follow the schematics log, I felt that this PIN should be set to low as SKL_S0_L is the decision maker for the OR gate based on the S0ix flow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6b5e066f228ea5dc79ae14dd803fc283fd248ce
Gerrit-Change-Number: 70196
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 15:28:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment