27 comments:
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
Patch Set #41, Line 4037: dram_freq_grp
const
Actually this is only used twice. Maybe we don't need it.
u8 rank_inctl = 0, tx_dly = 0, datlat_dsel = 0;
u8 rodt_tracking_mck = 0, root = 0, tx_rank_inctl = 0;
u8 tref_bw = 0, tfaw_05t = 0, trrd_05t = 0;
u16 xrtwtw = 0, xtrtrt = 0, xrtw2r = 0, xrtr2w = 0, tfaw = 0;
u16 trtw = 0, trtw_05t = 0, tmrr2w = 0, trrd = 0;
u16 phs_inctl = 0;
u32 rank_inctl_root;
Most of them don't need an initialized value. For others such as 'root', please declare with a 'const' modifier.
No need for the paratheses.
u
Patch Set #41, Line 4051: match
Found matched
error
Patch Set #41, Line 4056: , no match AC timing table
: no matched AC timing table found
Patch Set #41, Line 4059: memcpy
Can we use a pointer instead?
const struct ac_timing *ac_tim;
...
ac_tim = &ac_timing_tbl[table_idx];
Patch Set #41, Line 4072: rodt_tracking_mck
This is always 0. Why do we need this?
Patch Set #41, Line 4077: SHU_MISC_RX_PIPE_CTRL_RX_PIPE_BYPASS_EN
Please align with &ch[0].
Patch Set #41, Line 4080: ac_tim.datlat
What if this is 0?
Patch Set #41, Line 4085: info
err or warn?
File src/soc/mediatek/mt8192/dramc_pi_main.c:
Patch Set #41, Line 11: u8 rf_group = 0, cab_id = 0;
No need for initialization.
Remove "t"
Add a trailing ","
Since it's a one-to-one mapping, can we use dram_freq_grp directly?
Add a trailing ","
const
Patch Set #41, Line 40: dram_freq_grp
const
Patch Set #41, Line 42: ptRFCab_Opt
Lowercase
Patch Set #41, Line 43: tRFCab_Opt
Lowercase
Patch Set #41, Line 171: size_t
u8
Patch Set #41, Line 173: SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFC_05T, trfc_05t);
line over 96 characters
Please fix this
Patch Set #41, Line 176: SET32_BITFIELDS(&ch[chn].ao.shu_ac_time_05t, SHU_AC_TIME_05T_TRFCPB_05T, trfrc_pb05t);
line over 96 characters
Please fix this
u
File src/soc/mediatek/mt8192/include/soc/dramc_ac_timing.h:
t
One blank line before endif
To view, visit change 44713. To unsubscribe, or for help writing mail filters, visit settings.