Patch set 7:Code-Review +1
4 comments:
File src/mainboard/lenovo/x201/devicetree.cb:
I've seen this called "PCI bridge". P2P reminds me too much of P2SB
File src/southbridge/intel/ibexpeak/pch.c:
#ifdef __SIMPLE_DEVICE__
pci_devfn_t dev = PCI_DEV(0, 0x1f, 0);
#else
struct device *dev = pcidev_on_root(0x1f, 0);
#endif
is this how __SIMPLE_DEVICE__ is meant to be used? IMHO it looks wrong to me
if (pch_type < 0)
pch_type = pci_read_config8(dev, PCI_DEVICE_ID + 1);
return pch_type;
How does this work?
double empty line
To view, visit change 35753. To unsubscribe, or for help writing mail filters, visit settings.