Patrick Georgi submitted this change.
lib/cbfs: Don't load XIP stages from bootblock
This should improve boot times as it skips unnecessary read and
writes.
Change-Id: I8cf36613903783e741b2e3bfeeee5bc29ab26d5b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36323
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
---
M src/lib/cbfs.c
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 91368fb..1e8a93f 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -256,7 +256,7 @@
/* Hacky way to not load programs over read only media. The stages
* that would hit this path initialize themselves. */
- if (ENV_VERSTAGE && !CONFIG(NO_XIP_EARLY_STAGES) &&
+ if ((ENV_BOOTBLOCK || ENV_VERSTAGE) && !CONFIG(NO_XIP_EARLY_STAGES) &&
CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) {
void *mapping = rdev_mmap(fh, foffset, fsize);
rdev_munmap(fh, mapping);
To view, visit change 36323. To unsubscribe, or for help writing mail filters, visit settings.