Attention is currently required from: Jérémy Compostella.

Felix Held has uploaded this change for review.

View Change

[WIP] cpu/x86/smi_trigger: use call_smm

Use call_smm instead of writing the command number directly to the APMC
SMI command IO port.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iefbdb3d17932d6db6a17b5771436ede220c714fb
---
M src/cpu/x86/smi_trigger.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/79828/1
diff --git a/src/cpu/x86/smi_trigger.c b/src/cpu/x86/smi_trigger.c
index 56c7d44..7357dc5 100644
--- a/src/cpu/x86/smi_trigger.c
+++ b/src/cpu/x86/smi_trigger.c
@@ -38,7 +38,7 @@
apmc_log(__func__, cmd);

/* Now raise the SMI. */
- outb(cmd, pm_acpi_smi_cmd_port());
+ call_smm(cmd, 0, NULL);

printk(BIOS_DEBUG, "APMC done.\n");
return 0;

To view, visit change 79828. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iefbdb3d17932d6db6a17b5771436ede220c714fb
Gerrit-Change-Number: 79828
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-MessageType: newchange