Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 3:
(10 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 59: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 52: 0x1b
wait wtf, but I corrected it without realizing
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
PS1:
missed swap of NID 0x18 and 0x19
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 57: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a
wait wtf
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
PS1:
swap of NID 0x18 and 0x19 […]
Done with CB:37851 and CB:37852
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... PS1, Line 58: 0x1a
wait wtf
Done with CB:37851 and CB:37852