Attention is currently required from: Michael Niewöhner, Nicholas Chin.
Nicholas Chin uploaded patch set #3 to this change.
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
include/device/azalia_device.h: Add enum for misc field
The HDA specification defines bits 11:8 of the Configuration Default
register as a miscellaneous field for other jack information. Only bit 8
has a standard meaning, and indicates that the jack does not have
presence detect capability. Add an enum for use in the AZALIA_PIN_DESC
macro to indicate this field. Note that many vendor firmwares set bits
11:9 to non zero values despite them being reserved in the
specification, and their meaning in these cases is not well known.
Currently only mb/clevo/tgl-u/variants/l140mu uses the AZALIA_PIN_DESC
macro and has been updated to use the new enum. Other boards can be bulk
processed to switch from bare register values to the macro and enums in
a future patch.
Change-Id: I70cbfca8541828a1e0c7280887060c04e4c71721
Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com>
---
M src/include/device/azalia_device.h
M src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c
2 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/80452/3
To view, visit change 80452. To unsubscribe, or for help writing mail filters, visit settings.