Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.

Raul Rangel has uploaded this change for review.

View Change

soc/amd/{picasso/common}: Move populate_pirq_data to common

This method signature will also be used by cezanne, so move it to
common.

BUG=b:184766519
TEST=Build picasso

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I421bdad51776278f83148174e6f72bdc38249e54
---
M src/soc/amd/common/block/include/amdblocks/amd_pci_util.h
M src/soc/amd/picasso/fch.c
D src/soc/amd/picasso/include/soc/pci.h
M src/soc/amd/picasso/pcie_gpp.c
4 files changed, 3 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/52912/1

diff --git a/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h b/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h
index a14aecf..081741a 100644
--- a/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h
+++ b/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h
@@ -31,4 +31,7 @@
 void write_pci_int_table(void);
 const struct irq_idx_name *sb_get_apic_reg_association(size_t *size);
 
+/* Implemented by the SoC */
+void populate_pirq_data(void);
+
 #endif /* AMD_BLOCK_PCI_UTIL_H */
diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c
index e1c0eba..dcae1ad 100644
--- a/src/soc/amd/picasso/fch.c
+++ b/src/soc/amd/picasso/fch.c
@@ -23,7 +23,6 @@
 #include <soc/southbridge.h>
 #include <soc/smi.h>
 #include <soc/amd_pci_int_defs.h>
-#include <soc/pci.h>
 #include <soc/pci_devs.h>
 #include <types.h>
 #include "chip.h"
diff --git a/src/soc/amd/picasso/include/soc/pci.h b/src/soc/amd/picasso/include/soc/pci.h
deleted file mode 100644
index b6ff349..0000000
--- a/src/soc/amd/picasso/include/soc/pci.h
+++ /dev/null
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef AMD_PICASSO_PCI_H
-#define AMD_PICASSO_PCI_H
-
-void populate_pirq_data(void);
-
-#endif /* AMD_PICASSO_PCI_H */
diff --git a/src/soc/amd/picasso/pcie_gpp.c b/src/soc/amd/picasso/pcie_gpp.c
index 582e128..29dfe68 100644
--- a/src/soc/amd/picasso/pcie_gpp.c
+++ b/src/soc/amd/picasso/pcie_gpp.c
@@ -9,7 +9,6 @@
 #include <device/pci.h>
 #include <device/pciexp.h>
 #include <device/pci_ids.h>
-#include <soc/pci.h>
 #include <soc/pci_devs.h>
 #include <stdio.h>
 

To view, visit change 52912. To unsubscribe, or for help writing mail filters, visit settings.