HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41215 )
Change subject: mb/google/volteer: Add firmware configuration table ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41215/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41215/5/src/mainboard/google/voltee... PS5, Line 2: /* This file is part of the coreboot project. */ please remove
https://review.coreboot.org/c/coreboot/+/41215/5/src/mainboard/google/voltee... PS5, Line 4: #include <bootstate.h> : #include <commonlib/helpers.h> : #include <console/console.h> : #include <ec/google/chromeec/ec.h> : #include <fw_config.h> : #include <stdint.h> please include only what you use
https://review.coreboot.org/c/coreboot/+/41215/5/src/mainboard/google/voltee... PS5, Line 10: #include <soc/gpio.h> Please include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
(see https://review.coreboot.org/q/topic:%22soc_gpio%22+(status:open%20OR%20statu...) )