
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 ) Change subject: driver/thunderbolt: Driver for allocating hotplug resources ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... File src/drivers/thunderbolt/thunderbolt.c: https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 51: resource->flags |= IORESOURCE_IO;
since you don't know what's getting hot-plugged during runtime, you'll probably just have to reserve […] I think we should make the sizing configurable and not open/hard coded as it is currently. Likewise, we'll be seeing multiple usb4/thunderbolt devices in systems so these pre-allocations will be multiplied.
-- To view, visit https://review.coreboot.org/c/coreboot/+/35946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc Gerrit-Change-Number: 35946 Gerrit-PatchSet: 1 Gerrit-Owner: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Brandon Breitenstein <brandon.breitenstein@intel.com> Gerrit-CC: Divya S Sasidharan <divya.s.sasidharan@intel.com> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com> Gerrit-CC: Mimoja <coreboot@mimoja.de> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Subrata Banik <subrata.banik@intel.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 16:14:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de> Gerrit-MessageType: comment