Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35495 )
Change subject: trogdor: Provide initial mainboard support ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35495/8/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35495/8/src/mainboard/google/trogdo... PS8, Line 19: #if 0 Why is this commented out?
Rather than submitting this as a stub, I think I'd prefer to not select MAINBOARD_HAS_CHROMEOS for now and select that in a later patch when we have GPIO support and can submit this file with the right contents.
https://review.coreboot.org/c/coreboot/+/35495/8/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35495/8/src/mainboard/google/trogdo... PS8, Line 16: # TODO: update for Trogdor Isn't this updated now? Anything still missing?
https://review.coreboot.org/c/coreboot/+/35495/8/src/mainboard/google/trogdo... PS8, Line 22: #TODO: Move FMAP to 2M or 3M once FSG can be smaller The only thing I'd consider is doing this right away... I don't suppose you know how the FSG stuff works for SC7180?
Maybe put the FMAP at 0x200000 for now, that's a nice round alignment and still leaves over 1.5M for the FSG?