Attention is currently required from: Hung-Te Lin, Jarried Lin, Runyang Chen.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84896?usp=email )
Change subject: soc/mediatek/mt8196: Disable irq2axi feature ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84896/comment/09e3c19d_72cfbba5?usp... : PS1, Line 13: TEST=Build pass and the interrupt can be correctly handled. Please mention the problems/symptoms in the commit message.
Yes, we have checked it,
What do you refer to? `/proc/interrupts`?
File src/soc/mediatek/mt8196/irq2axi.c:
https://review.coreboot.org/c/coreboot/+/84896/comment/8f2b2e57_409fb157?usp... : PS3, Line 8: printk(BIOS_INFO, "%s\n", __func__); Please make it debug level or reword it. info level messages should be written, that users can understand it.
File src/soc/mediatek/mt8196/irq2axi_init.c:
https://review.coreboot.org/c/coreboot/+/84896/comment/ce2871be_a70457fb?usp... : PS1, Line 9: printk(BIOS_INFO, "%s irq uninit\n", __func__);
Done
I made a new comment.