Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49058 )
Change subject: mb/google/hatch (baseboard): add ACPI backlight support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@9 PS1, Line 9: H. : PUFF nit: either drop the line-break or add a full newline
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@10 PS1, Line 10: PUFF-based variants do not have an attached display
Um, this sounds like you're saying PUFF-based variants are headless. […]
agreed; when they are different devices, they should be split. I just wonder if the boards are the same (or at least 99% similiar).
Shouldn't be a blocker for that change, though. wdyt?