9 comments:
File src/soc/intel/tigerlake/cpu.c:
>=
Done
so, 28s is the default if out of range? […]
Done
Patch Set #4, Line 131: BIOS_DEBUG
Even log level INFO?
Done
extra indent?
Done
Patch Set #4, Line 161: printk(BIOS_DEBUG, "CPU PL2 = %u Watts\n", tdp_pl2 / power_unit);
Ditto.
Done
extra space
Done
be consistent about spaces around '=' in these messages […]
Done
File src/soc/intel/tigerlake/systemagent.c:
/* Configure turbo power limits 1ms after reset complete bit */
mdelay(1);
Why is this? Is this requirement captured anywhere?
We will get back on this.
If this is statically being set to 28, why does it have to be passed in as a parameter? Can't set_po […]
Need to check this kind of implementation.
To view, visit change 39346. To unsubscribe, or for help writing mail filters, visit settings.