[coreboot-gerrit] [L] Change in coreboot[master]: mb/inventec: Add Intel SPR server board Inventec Transformers

[Felix Singer (Code Review)]

Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )

Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers
......................................................................

Patch Set 10:

(4 comments)

Patchset:

PS10: 
Please add an entry to the MAINTAINERS file. In case of someone pushes a patch related to your mainboard, then you get automatically added as a reviewer and you get notified. You can add multiple people It's also helpful when questions appear and people want to contact you 😊

Your entry could look like this:

```
INVENTEC MAINBOARDS
M:	Annie Chen 
S:	Maintained
F:	src/mainboard/inventec/
```

The list is sorted, so please add it after Intel Harcuvar. You can add multiple people by adding more M lines.

File src/mainboard/inventec/Kconfig:

https://review.coreboot.org/c/coreboot/+/75598/comment/80adf561_c4127f36 :
PS10, Line 4: Manboard
typo: `Mainboard`

File src/mainboard/inventec/transformers/Kconfig:

https://review.coreboot.org/c/coreboot/+/75598/comment/18e588e7_24959405 :
PS8, Line 24: 	string
> @Felix Singer, mainboard_dir will bw used in our uboot and kernel, it's not useless define.

It's definitely useful and also needed. Sorry for being unclear.

I was just referring to the type declaration "string" since the types are already defined in other Kconfigs and so it's not needed here. In this case it's src/mainboard/Kconfig. So you can leave the setting. Just remove the types from this and the others please :)

File src/mainboard/inventec/transformers/ramstage.c:

https://review.coreboot.org/c/coreboot/+/75598/comment/4d0d9046_b1f5d2c7 :
PS8, Line 10: #define SLOT_ID_LEN 2
            : static char slot_id_str[SLOT_ID_LEN];
            : extern uint32_t heci_fw_sts(void);
            : extern uint32_t  heci_cse_normal(void);
            : extern uint32_t heci_cse_done(void);
            : 
            : //extern void cse_init(uintptr_t tempbar);
            :
> Done

It would be great if you could explain what these are doing.