Attention is currently required from: Werner Zeh, Jan Samek.

Patch set 3:Code-Review +1

View Change

5 comments:

• Commit Message:

  • Patch Set #3, Line 14:

    certain cases (like this one - emitting POST codes through a PCIe
    device).
    

    The text in parentheses feels a bit "loose". How about:

    ... in certain cases, such as emitting POST codes through a PCIe device.

  • Patch Set #3, Line 17: inicialization

    nit: ini*t*ialization

  • Patch Set #3, Line 18: IAFW

    IAFW BIOS spec

    Looks like the full document title is:
    ```
    Apollo Lake Platform
    Intel Architecture Firmware
    Specification (Volume 2 of 2)
    BIOS Specification
    ```

• Patchset:

  • Patch Set #3:

    Thanks for making this pretty! Will let Werner (or anyone else) give a +2, since we both authored this change.

• File src/mainboard/siemens/mc_apl1/bootblock.c:

  • Patch Set #3, Line 20: IAFW spec

    IAFW BIOS spec

To view, visit change 68223. To unsubscribe, or for help writing mail filters, visit settings.