Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35174
to look at the new patch set (#3).
Change subject: mb/google/poppy/variant/nocturne: fix EC_SYNC_IRQ definition ......................................................................
mb/google/poppy/variant/nocturne: fix EC_SYNC_IRQ definition
Setup EC_PCH_ARCORE_INT_L, tied to GPP_D17, as the EC_SYNC_IRQ line.
- change GPP_D17 definition to PAD_CFG_GPI_APIC_INVERT as EC_PCH_ARCORE_INT_L is active low
- enable itss for inverting the EC_SYNC_IRQ gpio for the APIC
- add EC_SYNC_IRQ to the group of chromeos_gpios for use by depthcharge
- change incorrect EC_SYNC_IRQ define from GPP_D17_IRQ to GPP_D17
BUG=b:139384979 BRANCH=none TEST="emerge_nocturne coreboot depthcharge chromeos-bootimage", flash & boot nocturne in dev mode, verify that volume up and down buttons work in the dev screen and that the device boots properly into the kernel.
Change-Id: Ia43c622710fde8686c60b836fb8318931d79eb61 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/variants/nocturne/gpio.c M src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h 3 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35174/3