4 comments:
File src/soc/amd/common/block/lpc/lpc.c:
Patch Set #4, Line 38: late_lpc_bridge_enable
If a function is supposed to be implemented by the SoC, it would be helpful to add _soc_ in its name and add a comment in the .h file indicating when it is supposed to be used/defined.
File src/soc/amd/common/block/lpc/lpc_util.c:
Patch Set #4, Line 36: struct
const
Patch Set #4, Line 40: TOTAL_WIDEIO_PORTS
Is this something that the SoC is supposed to provide? If this is always going to be 3, do we really need to get that from the SoC?
Patch Set #4, Line 188: (uintptr_t)
Is this typecast necessary?
To view, visit change 32653. To unsubscribe, or for help writing mail filters, visit settings.