9 comments:
Patch Set #4, Line 9: Add rtc MT6359P driver.
Please elaborate and add the datasheet name an revision.
Why can’t more common code be used?
File src/soc/mediatek/mt8192/rtc.c:
Patch Set #4, Line 31: pmif_arb->read_cmd
Why isn’t data of type `void`?
Patch Set #4, Line 51: dcxo clock
What is dcxo?
Patch Set #4, Line 350: //rtc_osc_init();
Why?
Patch Set #4, Line 353: mdelay(20);
Please add a comment why 20 ms delay is needed.
Please use one of the recommended styles [1].
https://doc.coreboot.org/coding_style.html#commenting
What is that?
Patch Set #4, Line 443: //rtc_write_field(PMIC_RG_DCXO_CW12, 0x0, 0x1, 0);
Why is this commented out?
To view, visit change 46395. To unsubscribe, or for help writing mail filters, visit settings.