Patch set 70:Code-Review +2
3 comments:
File src/security/tpm/tspi/crtm.c:
static const char * const fmap_cbfs_names[] = {
"COREBOOT",
"FW_MAIN_A",
"FW_MAIN_B",
"RW_LEGACY"};
this isn't really compliant with the code style. How about:
static const char *const fmap_cbfs_names[] = {
"COREBOOT",
"FW_MAIN_A",
"FW_MAIN_B",
"RW_LEGACY",
};
File src/security/tpm/tspi/tspi.c:
Patch Set #70, Line 235: printk(BIOS_DEBUG, "TPM: Extending digest for"
This string fits in one line without breaking (96-char limit)
Patch Set #70, Line 302: "measur" : "logg"
Ehm, I don't think saving two characters is that much of a big deal... Could we have full words in both cases of the ternary operator, please?
To view, visit change 35077. To unsubscribe, or for help writing mail filters, visit settings.