Attention is currently required from: Arthur Heymans, Nico Huber, Patrick Rudolph.
Patch set 7:Code-Review +1
8 comments:
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
Patch Set #4, Line 32: .macro find_free_mtrr
nit: Maybe don't indent this?
Done
Are you sure one can use names in an assembler macro?
It works if the macro is only used once per file, but it probably won't work if used more than once
Right. I would add a comment (suggestions welcome): […]
Ack
Patch Set #4, Line 122: cmp $0, %ebx
I'd use the idiomatic way: […]
Done
Patch Set #4, Line 123: jne 1f
Or even jz . […]
Done
Patch Set #4, Line 133: inc %ecx
Right. I wonder why "inc" is used here, but "incl" is used twice on the codepath below.
Ack
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
Patch Set #6, Line 161: find_free_mtrr
Looks like the suggestions didn't reach this block
Ack
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
cmp $0, %ebx
jne 1f
jmp .halt_forever
Simpler:
test %ebx, %ebx
jz .halt_forever
To view, visit change 37190. To unsubscribe, or for help writing mail filters, visit settings.