re
12 comments:
File src/mainboard/amd/padmelon/Kconfig:
Patch Set #15, Line 18: config HAVE_S3_SUPPORT
Will do.
Done
Patch Set #15, Line 22: Select it to change GPIO used for wake.
Correct, will remove the help.
Done
Patch Set #15, Line 64: config HWM_PORT
Will do.
It needs to be a config with this name... fintek code requires this to be defined.
Will do.
Done
File src/mainboard/amd/padmelon/acpi/superio.asl:
Patch Set #15, Line 49: #define SUPERIO_PNP_BASE 0x4E
Will check
Ack
Patch Set #15, Line 52: Device(SUPERIO_DEV) {
True, the whole file should be there. Will move.
Done, whole file removed as there's a newer one under superio/fintek/f81803a
File src/mainboard/amd/padmelon/board_info.txt:
Will have to verify. Will try.
Done
File src/mainboard/amd/padmelon/bootblock/OemCustomize.c:
Patch Set #15, Line 140: AzaliaCodecAlc286Table
Not sure, copy from Marc's code. Will double check.
Correct one is ALC662
adding appropriate hda_ver.c and changing Kconfig.
File src/mainboard/amd/padmelon/bootblock/bootblock.c:
Patch Set #15, Line 35: /* Remove this section if HW handshake is not needed */
They are needed for those who don't have a modified serial cable (connecting DCD to DTR and DSR, plu […]
Done
File src/mainboard/amd/padmelon/dsdt.asl:
Will check best way.
0x4e is not defined anywhere else, except at devicetree.cb. There's also no header file where I could easely define it, would need to create one... Would that be acceptable?
Patch Set #15, Line 73: #include <superio/fintek/f81803a/acpi/superio.asl>
Will do.
Done
File src/mainboard/amd/padmelon/romstage.c:
* Copyright (C) 2015 Advanced Micro Devices, Inc.
*
This is a placeholder, if there ever is something platform specific to add to romstage. […]
Done
To view, visit change 33993. To unsubscribe, or for help writing mail filters, visit settings.