9 comments:
File src/drivers/apple/hybrid_graphics/gmux.c:
Patch Set #2, Line 108: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info;
line over 80 characters
Patch Set #2, Line 109: if (config->gmux_indexed) {
braces {} are not necessary for any arm of this statement
Patch Set #2, Line 118: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info;
line over 80 characters
Patch Set #2, Line 119: if (config->gmux_indexed) {
braces {} are not necessary for any arm of this statement
Patch Set #2, Line 128: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info;
line over 80 characters
Patch Set #2, Line 129: if (config->gmux_indexed) {
braces {} are not necessary for any arm of this statement
File src/drivers/apple/hybrid_graphics/hybrid_graphics.c:
Patch Set #2, Line 27: printk(BIOS_INFO, "Hybrid graphics enable_dev\n");
Prefer using '"%s...", __func__' to using 'enable_dev', this function's name, in a string
Patch Set #2, Line 48: brightness = gmux_index_read32(GMUX_PORT_BRIGHTNESS) & GMUX_BRIGHTNESS_MASK;
line over 80 characters
File src/drivers/apple/hybrid_graphics/romstage.c:
Patch Set #2, Line 32: printk(BIOS_INFO, "Hybrid graphics early_hybrid_graphics\n");
Prefer using '"%s...", __func__' to using 'early_hybrid_graphics', this function's name, in a string
To view, visit change 32719. To unsubscribe, or for help writing mail filters, visit settings.