Hello Patrick Rudolph, Angel Pons, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30270
to look at the new patch set (#4).
Change subject: nb/intel/haswell: Use DEVEN to disable devices ......................................................................
nb/intel/haswell: Use DEVEN to disable devices
This allows devices to be properly disabled when they are set to `off` in the devicetree, or when a device has its `enabled` property set to false.
A message is printed stating that a device is being disabled, even if it was already disabled via DEVEN. However, it could be useful to have this information, so such messages are kept.
The device 00:04.0 is a thermal sensor on the Acer C720, but it has not been named as such in this patch. This is because the public datasheets never formally acknowledge what the device is, and how it might differ across platforms.
Tested on a Supermicro X10SLM+-F. The Mini-HD audio is disabled now, silencing a warning from Linux.
Also tested on an Acer C720 (Google Peppy). Disabling "device 4" from devicetree.cb works.
Also tested on an ASRock H81M-HDS. For this device, and all other test devices, there were no regressions observed.
Change-Id: If1504e620967449a09f113a7c771a1ec30380644 Signed-off-by: Tristan Corrick tristan@corrick.kiwi --- M src/northbridge/intel/haswell/northbridge.c 1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/30270/4