Subrata Banik uploaded patch set #3 to this change.

View Change

cpu/intel/car: Skip stack integrity check if FSP_USES_CB_STACK is enable

With FSP2.1 FSP_USES_CB_STACK likely to be enable. Impacted platforms
are CML (FSP2.0 + FSP_USES_CB_STACK feature enable) and ICL.

Don't need to run code logic to check the integrity of stack if FSP and
coreboot both likely to make use of common stack. Notified by
CONFIG_FSP_USES_CB_STACK, its expected to print
"Smashed stack detected in romstage!" msg multiple time in that case.

This patch fixes CML/ICL platform printing "Smashed stack detected in romstage!"
multiple times. This prints might be misleading.

TEST=Build and boot CML-Hatch

With this CL

No "Smashed stack detected in romstage!" msg in serial log.

Without this CL

"Smashed stack detected in romstage!" 64 times in serial log after FSP-M
returns into coreboot.

Change-Id: I943eff1225b976dc4440a6ca6d02ceea378319f8
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
---
M src/cpu/intel/car/romstage.c
1 file changed, 12 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/35165/3

To view, visit change 35165. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I943eff1225b976dc4440a6ca6d02ceea378319f8
Gerrit-Change-Number: 35165
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Usha P <usha.p@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset