8 comments:
File payloads/libpayload/include/riscv/arch/asm.h:
Patch Set #2, Line 14: #define ALIGN .align 2
Macros with complex values should be enclosed in parentheses
Patch Set #2, Line 16: #define ENDPROC(name) \
Macros with multiple statements should be enclosed in a do - while loop
Patch Set #2, Line 17: .type name, %function; \
need consistent spacing around '%' (ctx:WxV)
Patch Set #2, Line 20: #define ENTRY(name) \
Macros with multiple statements should be enclosed in a do - while loop
Patch Set #2, Line 21: .section .text.name, "ax", %progbits; \
need consistent spacing around '%' (ctx:WxV)
Patch Set #2, Line 24: name:
labels should not be indented
Patch Set #2, Line 26: #define END(name) \
Macros with complex values should be enclosed in parentheses
Patch Set #2, Line 27: .size name, .-name
space required before that '-' (ctx:VxV)
To view, visit change 31356. To unsubscribe, or for help writing mail filters, visit settings.