Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
soc/intel/skylake: Always print ME FW SKU

State of ME firmware SKU is independent of power-down mitigation.

Change-Id: I014c1697213efaefcb0c2a193128a876ef905903
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51204
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
---
M src/soc/intel/skylake/me.c
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index 92a7daf..89491f8 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -310,19 +310,19 @@
hfs3.fields.encrypt_key_check ? "FAIL" : "PASS");
printk(BIOS_DEBUG, "ME: PCH Configuration Info : %s\n",
hfs3.fields.pch_config_change ? "Changed" : "No Change");
+ }

- printk(BIOS_DEBUG, "ME: Firmware SKU : ");
- switch (hfs3.fields.fw_sku) {
- case ME_HFS3_FW_SKU_CONSUMER:
- printk(BIOS_DEBUG, "Consumer\n");
- break;
- case ME_HFS3_FW_SKU_CORPORATE:
- printk(BIOS_DEBUG, "Corporate\n");
- break;
- default:
- printk(BIOS_DEBUG, "Unknown (0x%x)\n",
- hfs3.fields.fw_sku);
- }
+ printk(BIOS_DEBUG, "ME: Firmware SKU : ");
+ switch (hfs3.fields.fw_sku) {
+ case ME_HFS3_FW_SKU_CONSUMER:
+ printk(BIOS_DEBUG, "Consumer\n");
+ break;
+ case ME_HFS3_FW_SKU_CORPORATE:
+ printk(BIOS_DEBUG, "Corporate\n");
+ break;
+ default:
+ printk(BIOS_DEBUG, "Unknown (0x%x)\n",
+ hfs3.fields.fw_sku);
}

printk(BIOS_DEBUG, "ME: FPF status : ");

To view, visit change 51204. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I014c1697213efaefcb0c2a193128a876ef905903
Gerrit-Change-Number: 51204
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged