3 comments:
File src/soc/intel/tigerlake/fsp_params_jsl.c:
Patch Set #16, Line 19: #include <fsp/ppi/mp_service_ppi.h>
Move it one line above so that it is consistent with the alphabetical order of include.
Patch Set #16, Line 47: config = config_of_soc();
Nit: declare and initialize in the previous line itself.
Patch Set #16, Line 65: sizeof(config->SerialIoUartMode));
Just curious: FSP UPD seems to support 7 I2C/GSPI/UART ports whereas in JSL there are 6,3 & 3 ports respectively. Are the UPDs for remaining ports in some reset/initialized state?
To view, visit change 38461. To unsubscribe, or for help writing mail filters, visit settings.