Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38445 )
Change subject: arch/x86/acpi_device: Add macros to define gpio interrupt with wake ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 308: .type = ACPI_GPIO_TYPE_INTERRUPT, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 309: .pull = ACPI_GPIO_PULL_DEFAULT, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 310: .irq.mode = ACPI_IRQ_LEVEL_TRIGGERED, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 311: .irq.polarity = ACPI_IRQ_ACTIVE_HIGH, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 312: .irq.wake = ACPI_IRQ_WAKE, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 313: .pin_count = 1, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 314: .pins = { (gpio) } }
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 318: .type = ACPI_GPIO_TYPE_INTERRUPT, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 319: .pull = ACPI_GPIO_PULL_DEFAULT, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 320: .irq.mode = ACPI_IRQ_LEVEL_TRIGGERED, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 321: .irq.polarity = ACPI_IRQ_ACTIVE_LOW, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 322: .irq.wake = ACPI_IRQ_WAKE, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 323: .pin_count = 1, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38445/1/src/arch/x86/include/arch/a... PS1, Line 324: .pins = { (gpio) } }
please, no spaces at the start of a line
Ack