2 comments:
File src/mainboard/google/octopus/variants/bobba/variant.c:
Patch Set #3, Line 17: #include <ec/google/chromeec/ec.h>
We don't need these two header files?
Patch Set #3, Line 30: return NULL;
Since filename is initialized to NULL, for sku_id not in the checking of line 32 we can just return NULL including SKU_UNKNOWN at line 36 already. As a result, we don't need this check and line 21?
To view, visit change 34542. To unsubscribe, or for help writing mail filters, visit settings.