6 comments:
Please elaborate, what DPM is, what it is used for, and where it’s documented.
Patch Set #5, Line 10: TEST=Boots correctly on Asurada
Tested with what firmware version, and how much time did it add? Maybe add the related coreboot log messages.
File src/soc/mediatek/mt8192/dpm.c:
Document the return values.
Patch Set #5, Line 23: size_t dm_file_size, pm_file_size;
Is the unit bytes? Add it to the variable name?
Patch Set #5, Line 38: printk(BIOS_INFO, "dm_file_size:%d, pm_file_size:%d\n",
Does the blob contain a version? Please print it out too.
Patch Set #5, Line 38: dm_file_size:%d, pm_file_size:%d
Please add a space after the colon and the units.
To view, visit change 46393. To unsubscribe, or for help writing mail filters, visit settings.