5 comments:
Patch Set #2, Line 13: TEST=Able to boot CML and TGL platform.
Are you able to reset them too? 😊
😎
File src/soc/intel/common/pch/reset/reset.c:
* BIOS should ensure it does a global reset
* to reset both host and Intel ME by setting
* PCH PMC [B0:D31:F2 register offset 0xAC bit 20]
*/
For running text, I'd prefer shorter lines. […]
Ack
/* Now BIOS can write 0x06 or 0x0E to 0xCF9 port
* to global reset platform */
Should fit in one line
Ack
/* If ME unable to reset platform then
* force global reset using PMC CF9GR register*/
I'd place the comment outside of the if-block, then it might fit in a single line. […]
Ack
Patch Set #2, Line 37: FSP_STATUS_RESET_REQUIRED_3
The only exceptions are Apollo Lake and Denverton-NS. […]
Ack
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.