Patch Set 4:

I've started to compare this to the spec, but... do we know
that the blob doesn't do this already?

Which blob? The MRC.bin, which I'm going to get rid of? ;)

BTW, the MRC version in MRC.bin is 1.6.0 build 0, and I assume the rest of RC (Reference Code) is also version 1.6.0 or similar. I know MRC version 1.9.0 comes with version 1.9.1 of the PCH RC. So, even if MRC did something, it may not be up-to-date.

I've implemented most of this after checking register dumps after booting with MRC. Without this patch, nearly all of the registers don't have the expected values, which means MRC doesn't do it. I think a few registers already had the correct values, but I don't know if that's their reset default value or if MRC actually programmed them, but since MRC is going to become optional, I decided to program all of them anyway. There's no harm in writing a few registers twice, and simplifies the future when MRC's reign of terror is eventually brought to an end. *laughs maniacally*

View Change

To view, visit change 47208. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f96f2106f3c23aeb694dd6fb343099fc5784e5
Gerrit-Change-Number: 47208
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 14 Nov 2020 11:30:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment