[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 12:

(3 comments)

https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... 
PS12, Line 47: 
dev_offset can also be just maintained across the three loops. Then you don't have to increment it in every iteration:

int i;
int dev_offset = 0;

for (i = 0; i < CONFIG_SOC_INTEL_I2C_DEV_MAX; i++, dev_offset++) {
}

for (i = 0; i < CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX; i++, dev_offset++) {
}

...

https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... 
PS12, Line 62: DevOffset
dev_offset

https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... 
PS12, Line 78: DevOffset
dev_offset